Question

Hello and thanks again for your great work on Saiku.

I would like to be able to load my custom formatter using Spring injection. so the code in OlapQueryService would be replaced by :

public ICellSetFormatter getFormatter(String formatter) {
    formatter = formatter == null ? "" : formatter.toLowerCase();
    String formatterBeanId = formatters.get(formatter);
    if (formatterBeanId != null) {
        return (ICellSetFormatter) appContext.getBean(formatterBeanId);
    }
    return (ICellSetFormatter) appContext.getBean(defaultFormatterBeanId);
}

public CellDataSet execute(String queryName, String formatter) {
    ICellSetFormatter cellSetFormatter = getFormatter(formatter);
    return execute(queryName, cellSetFormatter);
}

associated with the following spring declaration :

<bean id="cellSetFormatter" class="org.saiku.olap.util.formatter.CellSetFormatter" scope="prototype"/>
<bean id="hierarchicalCellSetFormatter" class="org.saiku.olap.util.formatter.HierarchicalCellSetFormatter" scope="prototype"/>
<bean id="flattenedCellSetFormatter" class="org.saiku.olap.util.formatter.FlattenedCellSetFormatter" scope="prototype"/>
<bean id="customCellSetFormatter" class="org.custom.formatter.customCellSetFormatter" scope="prototype"/>

<util:map id="formattersMap">
    <entry key="flat" value="cellSetFormatter"/>
    <entry key="hierarchical" value="hierarchicalCellSetFormatter"/>
    <entry key="flattened" value="flattenedCellSetFormatter"/>
    <entry key="custom" value="customCellSetFormatter"/>
</util:map>

<bean id="olapQueryBean" scope="session" class="org.saiku.service.olap.OlapQueryService">
    <property name="olapDiscoverService" ref="olapDiscoverServiceBean" />
    <property name="formatters" ref="formattersMap"/>
    <property name="defaultFormatterBeanId" value="flattenedCellSetFormatter"/>
</bean>

but I must add a dependency on spring inside saiku-service because it needs the applicationContext in order to get a new instance of the bean each time a query is done. what do you think about that ? I can do a git pull request.

Answer 1

yeh i thought about that already, and i agree we should springify the cellsetformatter

if you create a pull request i'll make sure that i'll look over it and apply it at some point (just need to find some time for the testing etc) i'd prefer not to add spring to saiku-service and either make this a SaikuProperty or define it in the context by adding this hashmap as property to a service or a helper class (or like you did in the query service itself)

couldn't we just make these formatter beans non-singletons?

-paul

Answer 2

Sorry for the delay I thought I would have received notifications about answers. We could make those formatters as singletons indeed, and that would be a lot more simple, as the singleton instance would be available directly in the hashmap, but there are class fields in some of them, like ignorex in FlattenedCellSetFormatter. Another possibility is to write a CellSetFormatter factory in saiku-web, that requires moving interface ICellSetFormatter in saiku-web.

Answer 3

0	true a factory sounds like the best option so far can you please log this in our issue tracker, otherwise i'll lose track of it... we can discuss the details there! link answered 24 Jan, 04:02 pstoellberger ♦♦ 897●2●7 accept rate: 5%

springify the CellSetFormatter

Follow this question

Related questions